fix(dict): cap max_dict_bytes at the u32 range BinaryView addresses - #9690
Open
mnshdw wants to merge 1 commit into
Open
fix(dict): cap max_dict_bytes at the u32 range BinaryView addresses#9690mnshdw wants to merge 1 commit into
mnshdw wants to merge 1 commit into
Conversation
Fixes vortex-data#9687 Signed-off-by: Antoine Dupuis <1048669+mnshdw@users.noreply.github.com>
mnshdw
force-pushed
the
fix/dict-max-bytes-u32-overflow
branch
from
August 28, 2026 14:39
810759b to
4d7d1a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit
max_dict_bytestou32::MAXso the builder can never be asked for a bound it cannot address