Attach RowFn validity directly to canonical output - #9694
Conversation
Merging this PR will regress 4 benchmarks
|
84cde9e to
c72fbbe
Compare
c72fbbe to
8df4c19
Compare
|
generally not a fan of optimisations like these... |
|
I think it shows a gap in our abstraction, ideally this is not required for this optimization? |
8df4c19 to
b464dd5
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
b464dd5 to
f17be3d
Compare
Summary
Attaches input-derived validity directly when a RowFn kernel already returns a canonical array, avoiding an extra lazy
vortex.maskexecution. Non-canonical output keeps the existing lazy mask path.Changes
Reuses
mask_validity_canonicalwithout copying canonical value buffers and preserves kernel-output validation, output relabeling, and outer nullability. Structural Boolean and primitive tests verify that nullable dense execution no longer runsvortex.mask.