Repository navigation
fix(kirari): classify TypeScript members after semicolons - #10
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fix TypeScript and TSX member names after semicolons being highlighted as variables. For example,
class Box { v: T; w: string }now highlights bothvandwas properties, consistent with interface and object type members.The shared scanner previously recognized property names only after
{and,. Extend that condition to;in existing TypeScript member scopes, preserving statement labels, constructor annotations, and function-valued member detection. No public API changes or dependencies.Closes #3
Validation
bun run checkandbun run testpass.mainshow only the intended member-category changes; token contents and offsets remain identical.The browser harness passes the new corpus fixtures, then hits an existing decoration line-count assertion failure also reproduced on untouched
main. Its remaining checks do not run. The docs build also reports five filesystem-tracing warnings in unchanged changelog code.Checklist
bun run checkpassesbunx changeset), or not needed for docs, tests, or internal changesSummary by CodeRabbit
Bug Fixes
Documentation
Tests