Skip to content

fix: highlight TypeScript enum declaration names - #7

Merged
ugi-dev merged 2 commits into
vortexkit:mainfrom
Madarame-Baku1:fix/typescript-enum-name-highlighting
Oct 21, 2026
Merged

ugi-dev merged 2 commits into
vortexkit:mainfrom
Madarame-Baku1:fix/typescript-enum-name-highlighting

Conversation

@Madarame-Baku1

@Madarame-Baku1 Madarame-Baku1 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes #5.

Adds enum to TypeScript declaration-name classification so enum Color and declare enum D names are tokenized as types. The corpus regression also guards interface, abstract class, and type alias names. Includes a changeset and docs changelog entry.

Validation:

  • bun run check passed on Ubuntu/WSL with Bun 1.3.11 and Node 26.12.0.
  • Focused corpus: 72 tests and 371,945 assertions passed.
  • git diff --check passed.

@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown

@Madarame-Baku1 is attempting to deploy a commit to the Vortex Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7e0d77b5-4f44-4452-a517-1f88dfb56da0
📥 Commits

Reviewing files that changed from the base of the PR and between 38f3861 and 913b3b0.

📒 Files selected for processing: 1
  • sites/docs/vercel.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The tokenizer now classifies TypeScript enum declaration names as type tokens. Tests cover related declaration forms. Release metadata records the fix. Vercel deployments are limited to main.

Changes

TypeScript declaration-name classification

Layer / File(s) Summary
Tokenizer classification and validation
packages/kirari/src/tokenize.ts, packages/kirari/test/corpus/fixtures.ts, .changeset/clear-masks-improve.md, sites/docs/changelog/kirari/1.1.1.md
Identifiers following enum now receive the type token classification. The fixture covers enum, declare enum, interface, abstract class, and type declarations. Release metadata records the fix.

Deployment branch configuration

Layer / File(s) Summary
Vercel branch deployment settings
sites/docs/vercel.json
Deployments are disabled for all branches and enabled for main.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related issues

  • vortexkit/kirari#5 — The tokenizer change addresses the reported classification of TypeScript enum names as variables.
Merge Risk: ⚪ Minimal · up to 913b3

No merge-blocking issue was identified in the PR.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Out of Scope Changes check Warning The TypeScript tokenizer change, corpus regression, changeset, and changelog support issue #5. The change to sites/docs/vercel.json disables deployments for all branches except main. This deployme… Remove the unrelated sites/docs/vercel.json deployment configuration change, or provide a directly linked coding requirement that requires it.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: highlighting TypeScript enum declaration names.
Linked Issues check Passed Issue #5 requires TypeScript declaration names to receive the type classification for enum, declare enum, interface, abstract class, and type aliases. packages/kirari/src/tokenize.ts classifies a …
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Full details: Linked Issues check

Explanation

Issue #5 requires TypeScript declaration names to receive the type classification for enum, declare enum, interface, abstract class, and type aliases. packages/kirari/src/tokenize.ts classifies a name as type when the previous value is enum, interface, or type. The corpus fixture verifies Color, D, I, A, and K as type.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

Full details: Out of Scope Changes check

Explanation

The TypeScript tokenizer change, corpus regression, changeset, and changelog support issue #5. The change to sites/docs/vercel.json disables deployments for all branches except main. This deployment configuration change has no demonstrated connection to TypeScript enum name classification.

Resolution

Remove the unrelated sites/docs/vercel.json deployment configuration change, or provide a directly linked coding requirement that requires it.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit hops where enum names glow
Type tokens guide them in a row
Fixtures check each declared name
Release notes record the change
Branches rest except main today
Hoppity code goes on its way

Comment @coderabbitai help to get the list of available commands.

@ugi-dev

ugi-dev commented Oct 21, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-21T09:01:25.779656Z
We couldn’t complete this review. Comment @codex review to try again.
c40b706 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
kirari Ready Ready Preview Oct 21, 2026 12:16pm UTC

Request Review

ugi-dev
ugi-dev previously approved these changes Oct 21, 2026

@ugi-dev ugi-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution, @Madarame-Baku1!

@ugi-dev
ugi-dev force-pushed the fix/typescript-enum-name-highlighting branch from 38f3861 to 913b3b0 Compare October 21, 2026 12:17
@ugi-dev
ugi-dev merged commit 61e5c2c into vortexkit:main Oct 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript

2 participants