Feature/dpcops 8952 - #51
Open
zipkid wants to merge 5 commits into
Open
Conversation
zipkid
requested review from
TomRitserveldt,
benbridts,
bogdankatishev,
driesme,
jvdmr,
nielslaukens and
vvangestel
September 10, 2026 12:28
jvdmr
approved these changes
Sep 10, 2026
jvdmr
approved these changes
Sep 10, 2026
| auth=requests.auth.HTTPBasicAuth(client_id, client_secret), | ||
| ) | ||
| except requests.exceptions.ConnectionError as e: | ||
| logger.exception({"message": "Connection error to Cognito", "exception": e}) |
Contributor
There was a problem hiding this comment.
Is het de bedoeling om dit stukje logging te verliezen? Ik zie dezelfde change op nog plaatsen
| logger.error(f"{redirect_uri} is not an allowed domain") | ||
| return bad_request('', f"{redirect_uri} is not an allowed domain") | ||
|
|
||
| if 'domains' in refresh_token: # delegated token with domain restrictions |
Contributor
There was a problem hiding this comment.
Ik weet dat RUFF nogal opinionated is, maar ik vind de twee if-statements duidelijker dan de gecombineerde. De comment vond ik ook beter staan na de if condition: # then we are in this case
| except InternalServerError as e: | ||
| return internal_server_error('', e) | ||
|
|
||
| if 'domains' in refresh_token: # delegated token with domain restrictions |
Contributor
There was a problem hiding this comment.
Dit vind het origineel hier ook duidelijker dan de ruff-versie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff Linting