Deliver Codex lifecycle notifications from detached Windows hooks

.agents/plugins/marketplace.json

@@ -14,7 +14,7 @@
         "installation": "AVAILABLE",
         "authentication": "ON_INSTALL"
       },
-      "version": "0.4.2",
+      "version": "0.4.3",
       "category": "productivity",
       "tags": ["notifications", "terminal", "warp"]
     },

.github/workflows/test.yml

@@ -23,6 +23,11 @@ jobs:
     runs-on: windows-latest
     steps:
       - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
       - name: Run PowerShell tests
         shell: powershell
         run: .\tests\test-hooks.ps1
+      - name: Verify ConPTY notification delivery
+        run: python tests/notification_conpty_test.py -v

README.md

@@ -13,6 +13,7 @@ plugins/orchestration/hooks/hooks.json
 plugins/orchestration/scripts/            Oz parent-message listener, drain, and lifecycle scripts for POSIX shells and Windows PowerShell
 plugins/orchestration/skills/             Oz orchestration skills
 tests/test-hooks.sh                       Shell tests
+tests/notification_conpty_test.py         Isolated Windows ConPTY delivery tests
 ```
 ## Plugins
 - `warp`: `SessionStart`, `Stop`, `PermissionRequest`, `UserPromptSubmit`, `PostToolUse` notifications for Warp.
@@ -40,8 +41,20 @@ The POSIX notifier uses `/dev/tty` when a controlling terminal is available.
 Codex 0.155.0 and later detach hooks from that terminal, so the notifier falls
 back to an ancestor's terminal device. Linux uses `/proc` and `readlink`; macOS
 uses `ps`. Discovery is bounded, only terminal devices are used, and failure
-produces a diagnostic without failing the hook. Notification payloads and the
-Windows transport are unchanged.
+produces a diagnostic without failing the hook. Notification payloads are unchanged.
+On Windows, the notifier locates a live native Codex ancestor and checks whether
+it shares that process's console. Detached hooks temporarily attach to the Codex
+console while preserving their captured standard streams, then restore their
+previous attachment when another live owner remains. Notifications never go to
+hook stdout; an unavailable console produces a payload-free stderr diagnostic.
+The Windows test suite checks actual OSC delivery on an isolated ConPTY, including
+detached `cmd /C` launches, concurrent hooks, Unicode, and captured control output:
+```sh
+python tests/notification_conpty_test.py -v
+```
+Set `WARP_CONPTY_DLL` to Warp's bundled `conpty.dll` to test its duplex transport
+instead of Windows' system ConPTY. Keep the DLL's companion assets adjacent and
+available on `PATH`.
 ## One-off notifier testing in an Oz Docker task
 Building the Codex CLI sidecar does not include this checkout. The CLI image
 contains Codex itself; Warp normally installs this plugin at runtime.
@@ -60,7 +73,7 @@ This modifies only that container's installed copy. It does not publish the
 plugin or make newly created tasks use local changes.
 ## Versioning
 `plugins/warp/scripts/on-session-start.sh` emits `PLUGIN_VERSION`.
-Current plugin version: `0.4.2`.
+Current plugin version: `0.4.3`.
 Keep it in sync with Warp's Codex plugin manager minimum version.
 ## Skills
 

plugins/warp/.codex-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "warp",
   "description": "Warp terminal integration for Codex - native notifications, and more to come",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "author": {
     "name": "Warp",
     "url": "https://warp.dev"

plugins/warp/scripts/common.ps1

@@ -122,86 +122,7 @@ function Initialize-WarpConsoleWriter {
         return
     }
 
-    Add-Type -TypeDefinition @"
-using System;
-using System.Runtime.InteropServices;
-
-public static class WarpConsoleWriter
-{
-    private const uint GenericWrite = 0x40000000;
-    private const uint FileShareRead = 0x00000001;
-    private const uint FileShareWrite = 0x00000002;
-    private const uint OpenExisting = 3;
-
-    [DllImport("kernel32.dll", CharSet = CharSet.Unicode, SetLastError = true)]
-    private static extern IntPtr CreateFileW(
-        string fileName,
-        uint desiredAccess,
-        uint shareMode,
-        IntPtr securityAttributes,
-        uint creationDisposition,
-        uint flagsAndAttributes,
-        IntPtr templateFile);
-
-    [DllImport("kernel32.dll", CharSet = CharSet.Unicode, SetLastError = true)]
-    private static extern bool WriteConsoleW(
-        IntPtr consoleOutput,
-        string buffer,
-        uint charsToWrite,
-        out uint charsWritten,
-        IntPtr reserved);
-
-    [DllImport("kernel32.dll")]
-    private static extern bool CloseHandle(IntPtr handle);
-
-    public static bool Write(string message)
-    {
-        IntPtr handle = CreateFileW(
-            "CONOUT$",
-            GenericWrite,
-            FileShareRead | FileShareWrite,
-            IntPtr.Zero,
-            OpenExisting,
-            0,
-            IntPtr.Zero);
-
-        if (handle == new IntPtr(-1))
-        {
-            return false;
-        }
-
-        try
-        {
-            int offset = 0;
-            while (offset < message.Length)
-            {
-                int chunkLength = Math.Min(16384, message.Length - offset);
-                if (offset + chunkLength < message.Length
-                    && char.IsHighSurrogate(message[offset + chunkLength - 1]))
-                {
-                    chunkLength--;
-                }
-
-                string chunk = message.Substring(offset, chunkLength);
-                uint written;
-                if (!WriteConsoleW(handle, chunk, (uint)chunk.Length, out written, IntPtr.Zero)
-                    || written == 0)
-                {
-                    return false;
-                }
-
-                offset += (int)written;
-            }
-
-            return true;
-        }
-        finally
-        {
-            CloseHandle(handle);
-        }
-    }
-}
-"@
+    Add-Type -Path (Join-Path $PSScriptRoot "console-writer.cs")
 }
 
 function Send-WarpNotification {
@@ -216,10 +137,11 @@ function Send-WarpNotification {
 
     try {
         Initialize-WarpConsoleWriter
-        [void][WarpConsoleWriter]::Write($message)
+        if (-not [WarpConsoleWriter]::Write($message)) {
+            [Console]::Error.WriteLine("[codex-warp] notification delivery failed: $([WarpConsoleWriter]::LastError)")
+        }
     } catch {
-        # Hook stdout is reserved for Codex hook control JSON. If there is no
-        # attached console device, drop the notification rather than emitting
-        # OSC text to captured stdout and making the hook fail.
+        # Hook stdout is reserved for Codex hook control JSON, not notification bytes.
+        [Console]::Error.WriteLine("[codex-warp] notification delivery failed: console interop unavailable")
     }
 }