Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Restore existing safety comments unless a change adds a concrete proof, corrects an inaccurate claim, or satisfies per-site linting. Keep newly required comments concise. Co-Authored-By: Claude Code <noreply@anthropic.com>
passcod
force-pushed
the
process-safety-hardening
branch
from
September 23, 2026 16:13
e0ceb53 to
900d0be
Compare
Treat a descendant PID file as ready only after it contains a parseable PID, rather than when shell redirection first creates the path. Cover the empty-then-populated transition and share the polling logic across both rollback fixtures. Co-Authored-By: Claude Code <noreply@anthropic.com>
Reuse an existing shell through a newly created symlink instead of writing and immediately executing a temporary script. This preserves the failed-spawn reuse check without exposing it to ETXTBSY from the fixture itself. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR hardens the crate’s documented unsafe boundaries and adds CI enforcement for the proofs that can be checked mechanically.
Summary
SAFETY:rationales for Unix, Windows, PTY, descriptor-transfer, child-I/O, and test-fixture unsafe operationspre_execAPIsunsafe_op_in_unsafe_fn,unused_unsafe,missing_safety_doc, andundocumented_unsafe_blocksThis PR intentionally makes no runtime behavior, public API signature, private safety-signature, or wrapper-semantics changes. The Miri jobs deliberately exclude native process creation and FFI execution; they exercise only process-free paths that Miri can model.
🤖 Generated with Claude Code