feat: Check per-node shard status in wait_for_vector_indexing - #2127
Open
bevzzz wants to merge 6 commits into
Open
feat: Check per-node shard status in wait_for_vector_indexing#2127bevzzz wants to merge 6 commits into
bevzzz wants to merge 6 commits into
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
==========================================
+ Coverage 86.64% 88.51% +1.87%
==========================================
Files 300 304 +4
Lines 23172 23473 +301
==========================================
+ Hits 20077 20778 +701
+ Misses 3095 2695 -400 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bevzzz
added a commit
to weaviate/weaviate
that referenced
this pull request
Aug 11, 2026
The linked PR adds per_node_status to the Python client and enables us to wait_for_vector_indexing correctly. weaviate/weaviate-python-client#2127
bevzzz
added a commit
to weaviate/weaviate
that referenced
this pull request
Aug 13, 2026
The linked PR adds per_node_status to the Python client and enables us to wait_for_vector_indexing correctly. weaviate/weaviate-python-client#2127
bevzzz
force-pushed
the
fix/wait-for-vector-indexing
branch
from
August 13, 2026 15:55
ce71fb3 to
05b3195
Compare
bevzzz
force-pushed
the
fix/wait-for-vector-indexing
branch
from
August 13, 2026 15:56
05b3195 to
4f3d340
Compare
tsmith023
reviewed
Aug 13, 2026
| name: str | ||
| status: ShardTypes | ||
| vector_queue_size: int | ||
| status: Optional[ShardTypes] |
Member
There was a problem hiding this comment.
With the change on the server, should this go back to being ShardTypes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is going to deprecate
shard.statusandshard.vectorQueueSizefields and introduceper_node_statusin its stead. We need to updatewait_for_vector_indexingto use this information when waiting for shards to get READY.