-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add spa support for CSRF by setting into cookie #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
svenzik
wants to merge
1
commit into
main
Choose a base branch
from
WE2-1240
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // SPDX-FileCopyrightText: Estonian Information System Authority | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| "use strict"; | ||
|
|
||
| const CSRF_COOKIE_NAME = "XSRF-TOKEN"; | ||
| const CSRF_COOKIE_HEADER_NAME = "X-XSRF-TOKEN"; | ||
|
|
||
| export function csrfHeader() { | ||
| const cookieToken = getCookie(CSRF_COOKIE_NAME); | ||
| if (cookieToken) { | ||
| return {[CSRF_COOKIE_HEADER_NAME]: cookieToken}; | ||
| } | ||
|
|
||
| const metaToken = document.querySelector("#csrftoken")?.content; | ||
| const metaHeaderName = document.querySelector("#csrfheadername")?.content; | ||
| if (metaToken && metaHeaderName) { | ||
| return {[metaHeaderName]: metaToken}; | ||
| } | ||
|
|
||
| return {}; | ||
| } | ||
|
|
||
| function getCookie(name) { | ||
| const encodedName = encodeURIComponent(name) + "="; | ||
| return document.cookie | ||
| .split(";") | ||
| .map(cookie => cookie.trim()) | ||
| .filter(cookie => cookie.startsWith(encodedName)) | ||
| .map(cookie => decodeCookieValue(cookie.substring(encodedName.length))) | ||
| .shift(); | ||
| } | ||
|
|
||
| function decodeCookieValue(value) { | ||
| try { | ||
| return decodeURIComponent(value); | ||
| } catch { | ||
| return value; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
example/src/test/java/eu/webeid/example/SpaCsrfConfigurationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| // SPDX-FileCopyrightText: Estonian Information System Authority | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| package eu.webeid.example; | ||
|
|
||
| import jakarta.servlet.Filter; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.boot.test.context.SpringBootTest; | ||
| import org.springframework.http.HttpHeaders; | ||
| import org.springframework.http.HttpStatus; | ||
| import org.springframework.mock.web.MockHttpServletResponse; | ||
| import org.springframework.test.context.web.WebAppConfiguration; | ||
| import org.springframework.test.web.servlet.setup.MockMvcBuilders; | ||
| import org.springframework.web.context.WebApplicationContext; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; | ||
|
|
||
| @SpringBootTest(properties = "web-eid-auth-token.csrf.use-spa-configuration=true") | ||
| @WebAppConfiguration | ||
| class SpaCsrfConfigurationTest { | ||
|
|
||
| @Autowired | ||
| private WebApplicationContext context; | ||
|
|
||
| @Autowired | ||
| private Filter[] springSecurityFilterChain; | ||
|
|
||
| @Test | ||
| void rootWhenSpaCsrfConfigurationIsEnabledWritesReadableXsrfTokenCookie() throws Exception { | ||
| MockHttpServletResponse response = MockMvcBuilders.webAppContextSetup(context) | ||
| .addFilters(springSecurityFilterChain) | ||
| .build() | ||
| .perform(get("/")) | ||
| .andReturn() | ||
| .getResponse(); | ||
|
|
||
| assertThat(response.getStatus()).isEqualTo(HttpStatus.OK.value()); | ||
| assertThat(response.getHeader(HttpHeaders.SET_COOKIE)) | ||
| .startsWith("XSRF-TOKEN=") | ||
| .containsPattern("XSRF-TOKEN=[^;]+") | ||
| .contains("Path=/") | ||
| .contains("Domain=ria.ee") | ||
| .doesNotContain("HttpOnly"); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.