Repository navigation
Fire toolactivated after invoking execute - #371
Merged
domfarolino merged 2 commits intoNov 9, 2026
Merged
domfarolino merged 2 commits into
domfarolino merged 2 commits into
Conversation
Fires the toolactivated event after invoking the tool's execute callback, so listeners observe the tool's synchronous effects. This matches Chromium and WPT. Fixes webmachinelearning#332
Collaborator
|
@sjdallst2, do you want to take a first pass at this PR? |
sjdallst2
reviewed
Nov 4, 2026
sjdallst2
requested changes
Nov 4, 2026
sjdallst2
approved these changes
Nov 5, 2026
sjdallst2
left a comment
sjdallst2
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the change, @beaufortfrancois !
Collaborator
Author
|
@domfarolino Once this PR is merged, I'll resume w3c-oss/webmcp-polyfill#7 |
github-actions Bot
added a commit
that referenced
this pull request
Nov 9, 2026
SHA: f2f2ae2 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
4 tasks done
beaufortfrancois
added a commit
to w3c-oss/webmcp-polyfill
that referenced
this pull request
Nov 10, 2026
Follow webmachinelearning/webmcp#245: define the ToolActivatedEvent and ToolCancelEvent interfaces, add the ontoolactivated and ontoolcancel handlers to ModelContext, and dispatch the events at the ModelContext of the document that owns the tool. Bump webmcp-types to 0.1.10 for the declarations. Follow webmachinelearning/webmcp#371 (draft f2f2ae2) for timing: toolactivated fires after the execute callback is invoked, so listeners observe its synchronous effects. If the callback detaches its document, DOM's inner invoke skips the listeners. toolcancel fires when a caller aborts a callback that has started and not settled. All pinned IDL checks, the ToolActivatedEvent tests, and executeTool-abort's caller-abort case now pass. Record the remaining expected failures: isTrusted is false for script-dispatched events, blank.html frames have no polyfill, and aborting before dispatch skips the callback. Validation: 253 browser tests and packed consumer checks pass. WPT in Chrome Canary 159.0.8153.0: 70 files, 190 subtests, zero unexpected results.
Collaborator
Author
|
Thank you both! |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fires the
toolactivatedevent after invoking the tool'sexecutecallback, so listeners observe the tool's synchronous effects (e.g. a filled-in declarative form). This matches Chromium and WPT (executeTool-abort.https.html).No explicit fully active guard is needed: if
executedetaches the document, DOM's inner invoke already skips listeners when the target's relevant global object's associated Document is not fully active, matchingexecuteTool-detach-toolactivated.https.html.Fixes #332
Preview | Diff