feat: Migrate to Webpack Built-in Infrastructure Logger with Backward… - #738
Open
ronakmaheshwari wants to merge 1 commit into
Open
feat: Migrate to Webpack Built-in Infrastructure Logger with Backward…#738ronakmaheshwari wants to merge 1 commit into
ronakmaheshwari wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: ad3efed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logging system of the
webpack-bundle-analyzerplugin to integrate with Webpack's native infrastructure logger when available. It introduces a new adapter for compatibility, deprecates the plugin'slogLeveloption in favor of Webpack'sinfrastructureLogging, and updates documentation and type annotations accordingly.Logging integration and deprecation:
compiler.getInfrastructureLogger('webpack-bundle-analyzer')when available, providing better integration with Webpack's logging system.logLeveloption is deprecated in favor of Webpack'sinfrastructureLogging.level, with documentation and type comments updated to reflect this change. A deprecation warning is shown iflogLevelis used. [1] [2] [3] [4] [5]Logger implementation and type updates:
InfrastructureLoggerAdapterinLogger.jsto bridge between the plugin's logger interface and Webpack's infrastructure logger, supporting log level filtering and deprecation warnings. [1] [2] [3]src/analyzer.js,src/utils.js,src/viewer.js) to accept either the customLoggeror Webpack's infrastructure logger for improved type safety and compatibility. [1] [2] [3] [4] [5] [6] [7]These changes ensure that logging is consistent with Webpack's ecosystem and prepare for the eventual removal of the plugin's custom
logLeveloption compatibility#358
@valscion if you can review it