Repository navigation
chore: note the security defaults to change in the next major release - #5775
alexander-akait wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UjuMAuk9o6UazjHzcAQCTA
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe change adds TODO comments in Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5775 +/- ##
=======================================
Coverage 95.79% 95.80%
=======================================
Files 6 6
Lines 5539 5551 +12
=======================================
+ Hits 5306 5318 +12
Misses 233 233 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Adds TODOs, as code comments only, for the security defaults to change in the next major release. They join the ones #5770 already left:
allowedOriginsdefaulting to[],allowedHosts/headersno longer granting origins,static.denyon by default, and the hot token for every client.hostdefaults to"localhost"(listen()). With nohost, Node listens on every interface, so the server, its sources and the internal endpoints are reachable from the whole network by default. Reaching it from another machine should takehost: "0.0.0.0","local-ip"or an address.static.serveIndexdefaults tofalse(static option defaults). A directory listing names every file in it, so turning it on should be explicit./webpack-dev-server/invalidateand/webpack-dev-server/open-editorrequire the per-run token once it is handed to every client. Both act on the developer's machine, andSec-Fetch-*/Originare not sent over plainhttpto anything butlocalhost. The overlay's open-editor request then has to carry the token from webpack-dev-middleware's client.What kind of change does this PR introduce?
chore (comments only; no behaviour changes)
Did you add tests for your changes?
No; nothing to test. Lint passes and the generated types are unchanged.
Does this PR introduce a breaking change?
No. It records breaking changes for the next major release.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing now; the migration guide for the next major release should cover these.
Use of AI
Written with Claude Code, directed and reviewed by the author.
Generated by Claude Code
Summary by CodeRabbit