Improved Laravel 13 Support [Minimal PR] - #1546
Open
austinderrick wants to merge 1 commit into
Open
austinderrick wants to merge 1 commit into
austinderrick wants to merge 1 commit into
Conversation
- Allow laravel/framework ^13 next to ^12 in the root and module manifests. - Clone the arraysubset-asserts VCS repo without the GitHub API, so fork PR CI can install.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with wintercms/storm#246. Lets Winter 1.3 install on Laravel 13 while keeping Laravel 12. This is the slimmed-down alternative to #1487.
laravel/frameworkto^12.0|^13.0in the root and modulecomposer.jsonfiles. PHP stays at^8.2.no-apito the arraysubset-asserts repo so CI on fork PRs can install without a token.No code changes were needed in the modules. CI here will still run on Laravel 12 until storm#246 is merged, because Storm's
wip/1.3only allows 12 right now.IMPORTANT THINGS: