Repository navigation
Conversation
added 2 commits
November 6, 2026 16:09
CA-file does two things: federation uses it to verify its DTLS peers, and set_ctx_ex() applies it to the client-facing TLS/DTLS listeners, where it makes coturn require a client certificate (SSL_VERIFY_PEER | SSL_VERIFY_FAIL_IF_NO_PEER_CERT). Deployments set CA-file for federation, so every TURNS client without a certificate is rejected: the TLS 1.3 handshake completes, then the server sends certificate_required and resets the connection at the first Allocate. Wire clients have no client certificate, and browsers cannot present one to a TURN server. federation-CA-file gives federation its own CA bundle. set_ctx_ex() now takes the CA file as a parameter: the listeners pass CA-file (upstream meaning, client certificate authentication), federation passes federation-CA-file. When federation-CA-file is not set, federation falls back to CA-file, so existing configurations behave as before.
The chart set CA-file on every deployment ("mandatory for federated
DTLS"), even without federation. CA-file makes coturn require client
certificates on its TLS listener, so TURNS was unusable for clients.
Render the ca.* bundle as federation-CA-file inside the federate.dtls
block instead, and no longer set CA-file. Needs an image with
federation-CA-file: an older coturn ignores the unknown option with a
warning and runs DTLS federation without certificate validation.
|
Dusan Stevanovic seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
smatting
approved these changes
Nov 6, 2026
smatting
left a comment
smatting
left a comment
There was a problem hiding this comment.
I think this doesn't change the configuration surface, right? So that part I can approve.
However I can't review the changes in the c code.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR de-couples the federation CA-file fom the global CA-file that is used for TURNS TLS connections.