Repository navigation
Conversation
The main container puts the discovered external IP into a sed expression to fill the config template. The expression uses ";" as its delimiter. An address that contains ";" therefore becomes part of the expression instead of data. sed then fails and set -e stops the container, with an error that does not name the cause. The node ExternalIP field cannot hold such a value. The on-prem fallback annotation wire.com/external-ip is free-form and can. Check the value in the init container, where it first arrives, and reject it if it holds a character that an IP address cannot hold. The message names the node and the value. The allowed set is 0-9, a-f, A-F, ".", ":" and "%", so IPv4, IPv6, and an IPv6 zone index all pass. The set also excludes "&" and "\", which are the other two characters with a meaning in a sed replacement. Render-time substitution is not an option here, unlike in the sftd chart. The values are only known at run time, and they go into a config file. (cherry picked from commit 029956f)
bsinou
force-pushed
the
fix/external-ip-sed-injection-dev
branch
from
November 11, 2026 12:11
1700019 to
d34166f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #64 to
dev. The commit is cherry-picked from #64 unchanged and applies cleanly.The main container puts the external IP into a
sedexpression delimited by;. A value from the free-formwire.com/external-ipnode annotation that contains;breaks the expression, and the container stops with an error that doesn't name the cause. The init container now rejects any value with a character an IP address can't hold (allowed:0-9a-fA-F.:%) and logs the node and the value.See #64 for the full analysis and the manual test matrix.