feat: add dropdown option to "join now" meeting [WPB-27464] - #5153
Open
saleniuk wants to merge 4 commits into
Open
feat: add dropdown option to "join now" meeting [WPB-27464]#5153saleniuk wants to merge 4 commits into
saleniuk wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (42.85%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5153 +/- ##
===========================================
- Coverage 52.77% 52.76% -0.01%
===========================================
Files 659 659
Lines 23589 23608 +19
Branches 3881 3884 +3
===========================================
+ Hits 12448 12456 +8
- Misses 9994 10003 +9
- Partials 1147 1149 +2
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
…dropdown-menu-option # Conflicts: # features/meetings/src/main/java/com/wire/android/feature/meetings/ui/MeetingsViewModelFactory.kt
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-27464
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Added option in the dropdown menu for a meeting list item, to allow users to join the meeting anytime.
Testing
Test Coverage (Optional)
How to Test
Open dev-debug app, go to "Meetings", click on the "..." menu button for any item and try to "join now" - it should start/join a call for that meeting conversation.
Attachments (Optional)
join.now.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.