feat: show security providers info screen (WPB-27916) - #5156
Conversation
…-info-screen # Conflicts: # app/src/main/kotlin/com/wire/android/di/metro/WireMetroViewModelBindings.kt # app/src/main/kotlin/com/wire/android/ui/debug/DebugInfoViewModelFactory.kt
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5156 +/- ##
===========================================
- Coverage 52.77% 52.67% -0.10%
===========================================
Files 659 662 +3
Lines 23589 23633 +44
Branches 3881 3884 +3
===========================================
Hits 12448 12448
- Misses 9994 10038 +44
Partials 1147 1147
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
this will show all providers which is not the intendet behaivour |
| init { | ||
| viewModelScope.launch { | ||
| val providers = withContext(dispatcherProvider.default()) { | ||
| Security.getProviders().map { provider -> |
There was a problem hiding this comment.
This one here should come from the usages of SecureRandom.getInstanceStrong() under kalium:logic module.
The ticket has it https://wearezeta.atlassian.net/browse/WPB-27920
I also appended what Mo pointed out, since we have one instance in OAuthUseCase
There was a problem hiding this comment.
yes but that's a different ticket, I will raise PR for it later today
The ticket asks for a section that "displays entries for security providers," which is what this implements. the installed provider list with their entries What you're describing is different. Happy to build it, but could you update the AC since the scope changed? |
Good point, I oversight some info, I've updated the ticket(s) with a couple of things to consider:
|
3 participants
https://wearezeta.atlassian.net/browse/WPB-27916
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Show security providers info screen in debug settings screen
Screen_recording_20260811_122754.mp4
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.