fix(federator): record mock-federator requests atomically - #5437
Open
blackheaven wants to merge 2 commits into
Open
fix(federator): record mock-federator requests atomically#5437blackheaven wants to merge 2 commits into
blackheaven wants to merge 2 commits into
Conversation
Contributor
Author
|
I wonder if the MockServer should also be moved to tests, WDYT? |
zebot
added
the
ok-to-test
The mock federator recorded each served request with a non-atomic modifyIORef append. When galley fans out federated calls concurrently per remote domain, multiple Warp workers performed read-modify-write on the shared IORef and lost updates. The dropped write made testBulkGetQualifiedConvs (post conversations/list/v2) intermittently fail: the response was served but the request unrecorded, so the assertion over receivedRequests decoded to Nothing. Replace the non-atomic modifyIORef with atomicModifyIORef', and add a regression test that fires 50 concurrent requests at the mock and asserts all are recorded (fails intermittently before the fix, deterministic after).
blackheaven
force-pushed
the
gdifolco/fix-flaky-tests-testBulkGetQualifiedConvs
branch
from
August 11, 2026 09:50
8b0295c to
cb29499
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d