Fix fpga chip passing gate's internal table instead of chip entity to output function#3656
Merged
Merged
Conversation
… output function Because of this all gates that used WireLib.CanTool did not work in FPGA
Contributor
|
Might want to revisit this one. This causes gates which use variables on the table to explode. eg. Timer / Smoother gates set a variable on the gate called "Accum" in their :reset() function. 
gate.Reset is called on the Gate table, not the entity table, so these values are never initialized. when .output is called with the entity , it will not have these initial values on the entity table. 
Furthermore, any fields that the output functions attempt to access will now be shared for the entire FPGA instead of instanced. |
Astralcircle
added a commit
to Astralcircle/wire
that referenced
this pull request
Jul 18, 2026
…ntity to output function (wiremod#3656)" This reverts commit 6fdc26a.
Astralcircle
added a commit
that referenced
this pull request
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of this all gates that used WireLib.CanTool did not work in FPGA