fix chip crashes after duplicated in big dupes with persist tables#3657
Open
AlexALX wants to merge 4 commits into
Open
fix chip crashes after duplicated in big dupes with persist tables#3657AlexALX wants to merge 4 commits into
AlexALX wants to merge 4 commits into
Conversation
I found issue with my ALX PC chips crashing after paste duplication. Its a huge duplication so it has a big delay for paste, and something goes wrong during that. then when i run chip they crash due to table.remove is nil or table.unset is nil in all chips. While debugging i found that persist table variables missing metadata after paste, so e2 functions crashing because of that like: ``` sv: Expression 2 (Internet Connector): Runtime error 'entities/gmod_wire_expression2/core/table.lua:536: attempt to call method 'Unset' (a nil value)' at line -1, char -1 ``` with this change it completely fixes this issue. But have no idea if thats correct way. Correct me if i'm wrong. and i cannot provide easy steps to reproduce, unless share big duplication i have so you can test manually what i mean. Thanks.
AlexALX
changed the title
Contributor
Author
|
Tell me pls if this could be reviewed or how else to solve issue, since its last issue left before i can release my ALX PC upgrade (with requirement for wiremod canary). Thanks! |
thegrb93
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found issue with my ALX PC chips crashing after paste duplication. Its a huge duplication so it has a big delay for paste, and something goes wrong during that.
then when i run almost any chip - it crash due to table.remove is nil or table.unset is nil in all chips. While debugging i found that persist table variables missing metadata after paste, so e2 functions crashing because of that like:
It is just a
@persist NWData:tableand other tableswith this change it completely fixes this issue. But have no idea if thats correct way. Correct me if i'm wrong.
and i cannot provide easy steps to reproduce, unless share big duplication i have so you can test manually what i mean.
Thanks.