prepare WS DDP for ESP8266 compatibility, fix compiler warnings in pacman FX, remove omggif.js for ESP8266#5734
Open
DedeHai wants to merge 5 commits into
Open
prepare WS DDP for ESP8266 compatibility, fix compiler warnings in pacman FX, remove omggif.js for ESP8266#5734DedeHai wants to merge 5 commits into
DedeHai wants to merge 5 commits into
Conversation
Contributor
WalkthroughThe PR hardens PacMan position handling, adds ESP8266-specific DDP chunk sizing, and updates PixelForge resource loading, image-tab behavior, and GIF route compilation for ESP8266 and GIF support configurations. ChangesPacMan type handling
ESP8266 PixelForge support
DDP chunk sizing
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant PixelForge
participant fsMem
participant ResourceLoader
participant ImageTab
PixelForge->>fsMem: detect device architecture
fsMem-->>PixelForge: set is8266
PixelForge->>ResourceLoader: conditionally load omggif.js
PixelForge->>ImageTab: show image content or ESP8266 notice
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: pixelpaint and videolab tools will get an update too
Summary by CodeRabbit