Add test case for SHE secure boot#430
Merged
Merged
Conversation
padelsbach
force-pushed
the
add-she-secboot-test
branch
2 times, most recently
from
e649bac to
1ba25e9
Compare
padelsbach
force-pushed
the
add-she-secboot-test
branch
from
1ba25e9 to
0871f97
Compare
AlexLanzano
requested changes
Jul 13, 2026
AlexLanzano
left a comment
AlexLanzano
left a comment
Member
There was a problem hiding this comment.
Looks great! Just two small things. Will merge once addressed
AlexLanzano
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F-5471
Adds test cases to legacy and refactor for the checks in _ReportInvalidSheState. _ReportInvalidSheState has a tiny refactor and now allows GET_STATUS regardless of state, per SHE spec.