Repository navigation
Test refactor: add async RSA test cases - #553
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the added asynchronous RSA test coverage.
No open issues 🎉
What changed in this PR
Expands RSA coverage in test-refactor toward parity with the legacy tests by exercising asynchronous client/server APIs.
Changes:
- Adds invalid-argument checks for async RSA requests and responses.
- Tests cached-key generation, size queries, raw sign/verify, and undersized output handling.
- Tests asynchronous key export followed by an encrypt/decrypt round trip.
| File | Description |
|---|---|
test-refactor/client-server/wh_test_crypto_rsa.c |
Adds and registers async RSA argument, cached-key, and exported-key tests. |
Review effort: Balanced
padelsbach
force-pushed
the
test-refactor-rsa-split
branch
from
October 30, 2026 20:39
79b29eb to
acddb92
Compare
bigbrett
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a whopping ~50 lines of coverage in
test-refactor, but brings RSA into parity with the legacy tests.