Repository navigation
Do not register MD5, MD5-SHA1 and DES3 in FIPS builds - #522
Closed
padelsbach wants to merge 1 commit into
Closed
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
FIPS builds that disallow non-FIPS algorithms can still register MD5, MD5-SHA1, and DES3, leaving the cache-constants/error-queue failure unresolved despite skipping the test.
1 open issue
What changed in this PR
This PR aims to prevent FIPS algorithm initialization errors in wolfProvider. It adds a FIPS build variant with non-FIPS algorithms enabled and adjusts digest-related checks and tests.
Changes:
- Add configurable wolfSSL build options and a DES3-enabled FIPS Ready CI variant.
- Separate raw ECDSA signing and verification digest minimums, with compatibility fallbacks and updated boundary tests.
- Skip the MD5-SHA1 PRF test when non-FIPS algorithms are disallowed.
| File | Description |
|---|---|
test/test_tls1_prf.c |
Guard the MD5-SHA1 test in FIPS builds. |
test/test_ecc.c |
Test separate signing and verification digest minimums. |
src/wp_ecdsa_sig.c |
Apply operation-specific digest minimums. |
scripts/utils-wolfssl.sh |
Pass extra wolfSSL configure options. |
scripts/build-wolfprovider.sh |
Document the new configure-options variable. |
include/wolfprovider/internal.h |
Centralize digest-minimum compatibility fallbacks. |
.github/workflows/fips-ready.yml |
Add a DES3-enabled variant with a distinct cache key. |
Review effort: Balanced
Comment on lines
+534
to
+535
| #if defined(WP_HAVE_MD5_SHA1) && \ | ||
| (!defined(HAVE_FIPS) || defined(WP_ALLOW_NON_FIPS)) |
Contributor
Author
|
Mixed up the commits. See #523 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

get_paramsreturned 0 for these algs and drops the algs when init'ing the digest/cipher. It also leaves an error in the queue, and a non-blocking app will seeSSL_ERROR_SSLand error"OpenSSL Error: error:030000E1:digital envelope routines::cache constants failed"on its first TLS connection.Fixes zd 22723