Repository navigation
Fix the cppcheck 2.13 findings - #1357
Open
ejohnstown wants to merge 2 commits into
Open
ejohnstown wants to merge 2 commits into
ejohnstown wants to merge 2 commits into
Conversation
Restructure the two sites that left a redundant check in one build configuration, and suppress a warning that only appears in a configuration cppcheck invents. - wolfsshd.c: set the -h host key file in the else of the cert store conflict check instead of retesting ret. - internal.c CompositeEccSign: run wc_ecc_sig_to_rs from an else shared by the small-stack allocation check and the plain stack arrays. - wolfsftp.c: suppress constStatement on WWRITE; cppcheck's -DWWRITE configuration turns the arguments into a comma expression.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1357
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 3 of 3 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
The cppcheck step pipes through tee, so its exit code was lost and the job passed with findings. Run the step under bash, which sets pipefail, and upload the results file only when the step fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the four warnings cppcheck 2.13 reports on master.