Add crypto callback mode for SLH-DSA - #11055

Merged

philljj merged 7 commits into

wolfSSL:masterfrom

padelsbach:slh-dsa-cryptocb

Sep 9, 2026

padelsbach commented Aug 4, 2026 •

edited

Loading

Contributor

Description

Includes CB_ONLY mode for SLH-DSA which saves approx 16kB when enabled and offloaded.

Testing

New tests

Checklist

added tests
updated/added doxygen
updated appropriate READMEs
Updated manual and documentation

dgarske assigned padelsbach

padelsbach force-pushed the slh-dsa-cryptocb branch 2 times, most recently from cd65e2b to 41681d4 Compare

August 12, 2026 00:14

padelsbach requested a review from wolfSSL-Fenrir-bot

August 12, 2026 00:15

padelsbach marked this pull request as ready for review

August 12, 2026 00:15

github-actions Bot commented Aug 12, 2026

retest this please

github-actions Bot commented Aug 12, 2026 •

edited

Loading

MemBrowse Memory Report

linuxkm-pie

Data: __patchable_function_entries +32 B (+0.1%, 27,032 B)

linuxkm-standard

Data: __patchable_function_entries +32 B (+0.1%, 49,824 B)
No memory changes detected for:
gcc-arm-cortex-m0plus
gcc-arm-cortex-m3
gcc-arm-cortex-m4
gcc-arm-cortex-m4-baremetal
gcc-arm-cortex-m4-crypto-only
gcc-arm-cortex-m4-dtls13
gcc-arm-cortex-m4-min-ecc
gcc-arm-cortex-m4-openssl-compat
gcc-arm-cortex-m4-pkcs7
gcc-arm-cortex-m4-pq
gcc-arm-cortex-m4-rsa-only
gcc-arm-cortex-m4-sp-math
gcc-arm-cortex-m4-tls12
gcc-arm-cortex-m4-tls13
gcc-arm-cortex-m7
gcc-arm-cortex-m7-pq
gcc-arm-cortex-m7-tls13
stm32-sim-stm32h753

wolfSSL-Fenrir-bot reviewed

View reviewed changes

wolfSSL-Fenrir-bot left a comment

Fenrir Automated Review — PR #11055

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 13
13 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfcrypt/src/wc_slhdsa.c

wolfcrypt/test/test.c

wolfcrypt/test/test.c

wolfcrypt/src/wc_slhdsa.c

wolfcrypt/src/wc_slhdsa.c

tests/swdev/swdev.c

wolfcrypt/src/cryptocb.c

tests/swdev/swdev.c

wolfcrypt/src/wc_slhdsa.c

tests/api/test_slhdsa.c

padelsbach force-pushed the slh-dsa-cryptocb branch from 41681d4 to 1f5cc7b Compare

August 12, 2026 20:41

padelsbach commented

View reviewed changes

wolfcrypt/src/wc_slhdsa.c

padelsbach commented

View reviewed changes

wolfcrypt/src/wc_slhdsa.c

padelsbach commented

View reviewed changes

wolfcrypt/src/wc_slhdsa.c

padelsbach commented

View reviewed changes

wolfcrypt/src/wc_slhdsa.c

padelsbach commented

View reviewed changes

wolfcrypt/test/test.c

padelsbach commented

View reviewed changes

tests/swdev/swdev.c

padelsbach commented

View reviewed changes

tests/swdev/swdev.c

padelsbach commented

View reviewed changes

tests/api/test_slhdsa.c

padelsbach force-pushed the slh-dsa-cryptocb branch from 1f5cc7b to 7ca2ad8 Compare

August 12, 2026 23:08

padelsbach commented

View reviewed changes

wolfcrypt/test/test.c

padelsbach commented

View reviewed changes

wolfcrypt/src/wc_slhdsa.c

padelsbach commented

View reviewed changes

wolfcrypt/src/cryptocb.c

padelsbach commented

View reviewed changes

tests/swdev/swdev.c

padelsbach force-pushed the slh-dsa-cryptocb branch 2 times, most recently from 56ff337 to ca89c81 Compare

August 12, 2026 23:38

padelsbach commented

View reviewed changes

wolfcrypt/src/wc_slhdsa.c Outdated

padelsbach force-pushed the slh-dsa-cryptocb branch 2 times, most recently from 52202b8 to 85bb892 Compare

August 17, 2026 21:06

padelsbach commented Aug 21, 2026 •

edited

Loading

Contributor Author

jenkins retest this please

padelsbach force-pushed the slh-dsa-cryptocb branch from 85bb892 to e28419a Compare

August 21, 2026 17:22

padelsbach removed their assignment

padelsbach force-pushed the slh-dsa-cryptocb branch from 315dd6a to a87de7c Compare

August 25, 2026 20:13

padelsbach commented Aug 25, 2026

Contributor Author

Fenrir comments addressed. Back to you @philljj

padelsbach force-pushed the slh-dsa-cryptocb branch from a87de7c to 9829fb3 Compare

August 26, 2026 16:37

padelsbach assigned wolfSSL-Bot and unassigned padelsbach

philljj commented Aug 28, 2026

Contributor

Retest this please.

(no logs)

1 similar comment

philljj commented Aug 30, 2026

Contributor

Retest this please.

(no logs)

philljj self-requested a review

August 31, 2026 19:44

philljj reviewed

View reviewed changes

wolfcrypt/src/cryptocb.c Outdated

wolfcrypt/src/wc_slhdsa.c Outdated

wolfcrypt/src/wc_slhdsa.c Outdated

philljj assigned padelsbach and unassigned wolfSSL-Bot

padelsbach force-pushed the slh-dsa-cryptocb branch 3 times, most recently from e805763 to ee1f3aa Compare

September 4, 2026 17:40

padelsbach assigned wolfSSL-Bot and unassigned padelsbach

philljj commented Sep 8, 2026

Contributor

Retest this please.

(PRB preflight failed)

padelsbach added 6 commits

September 8, 2026 13:52


          Add crypto callback mode for SLH-DSA

e4f8a6f


          PR feedback: address re-entrance into callback

978f13d


          Address build matrix warnings

49a87cc


          PR feedback

1d06037


          Update configure.ac for slh-dsa

535cf34


          Address CI failures

82467fb

padelsbach force-pushed the slh-dsa-cryptocb branch from 7fab9de to 82467fb Compare

September 8, 2026 20:52


          PR feedback: add WC_PK_TYPE_PQC_SIG_KEYGEN_SEED, matching pattern in …

c8db2e1

…MLDSA PR

philljj self-requested a review

September 9, 2026 02:50

philljj commented Sep 9, 2026

Contributor

Tests good with various multi-test scenarios: all-crypto, wolfssl-all, clang, sanitize, smallstack, linuxkm, etc.

philljj approved these changes

View reviewed changes

philljj dismissed wolfSSL-Fenrir-bot’s stale review

September 9, 2026 15:55

addressed

philljj merged commit f670b0c into wolfSSL:master

387 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet