Forbird supported_versions when using TLS <1.3. Forbid sending more than one cert when using RPK. Confirm QUIC early_data_max_size matches expected value. - #11174
Open
kareem-wolfssl wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens TLS/QUIC and TLS 1.3 conformance checks in wolfSSL and adds regression tests covering those cases (F-9230, F-9231, F-9233).
Changes:
- Enforce QUIC NewSessionTicket early_data
max_early_data_sizesentinel value (0xffffffff) and add a QUIC regression test. - Reject
supported_versionsin a ServerHello when negotiating TLS < 1.3 and add a TLS 1.3 legacy_version downgrade-related regression test. - For TLS 1.3 + RPK, reject Certificate messages containing more than one CertificateEntry and add a corresponding test.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/quic.c | Adds a QUIC post-handshake ticket parsing test for early_data max size; fixes QUIC alert callback bookkeeping. |
| tests/api/test_tls13.h | Registers new TLS 1.3 API tests in the test list. |
| tests/api/test_tls13.c | Adds TLS 1.3 tests for multiple RPK cert entries and ServerHello legacy_version handling with supported_versions. |
| src/tls.c | Enforces QUIC early_data ticket size sentinel and rejects supported_versions in older-version ServerHello. |
| src/internal.c | Refactors negotiated peer cert-type lookup and rejects multi-entry Certificate lists when RPK is negotiated in TLS 1.3. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
wolfSSL-Fenrir-bot
requested changes
Aug 21, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11174
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
philljj
requested changes
Aug 22, 2026
kareem-wolfssl
force-pushed
the
fbatch1
branch
from
August 26, 2026 21:29
eb11281 to
0d679dc
Compare
philljj
requested review from
philljj and
wolfSSL-Fenrir-bot
and removed request for
wolfSSL-Fenrir-bot
August 27, 2026 21:34
wolfSSL-Fenrir-bot
requested changes
Aug 30, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11174
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
philljj
requested changes
Aug 31, 2026
philljj
left a comment
philljj
left a comment
Contributor
There was a problem hiding this comment.
Please review Fenrir items.
kareem-wolfssl
force-pushed
the
fbatch1
branch
from
August 31, 2026 17:13
0d679dc to
bf63312
Compare
Contributor
Author
|
Retest this please |
1 similar comment
Contributor
Author
|
Retest this please |
kareem-wolfssl
force-pushed
the
fbatch1
branch
from
September 4, 2026 18:31
bf63312 to
39df047
Compare
…hen using QUIC. Fixes F-9233.
…t codes as they differ from TLS alert codes.
Refactor QUIC alert handling into its own function Add test case for TLS 1.2 client + server to exercise new supported_version logic
kareem-wolfssl
force-pushed
the
fbatch1
branch
from
September 8, 2026 17:34
39df047 to
cbae46a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes F-9230, F-9231, F-9233
Testing
Built in tests + added tests
Checklist