aarch64: crypto-extension asm for the AES-XTS streaming path - #11386
aarch64: crypto-extension asm for the AES-XTS streaming path#11386kaleb-himes wants to merge 2 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ff675fa to
0a42f45
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
0a42f45 to
cef58d6
Compare
| static const word32 chunk_tail[] = { WC_AES_BLOCK_SIZE * 9, | ||
| WC_AES_BLOCK_SIZE * 4, | ||
| WC_AES_BLOCK_SIZE * 2, | ||
| WC_AES_BLOCK_SIZE + 5 }; |
There was a problem hiding this comment.
This was already fixed @wolfSSL-Fenrir-bot you appear to be spinning and not looking at the most recent commit.
cef58d6 to
61e0bc8
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11386
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
61e0bc8 to
a940add
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11386
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
2 participants
Description
Add the aarch64 streaming API's for user space
aarch64: AES-XTS streaming assembly and callers
Adds AES_XTS_encrypt_update_AARCH64 / AES_XTS_decrypt_update_AARCH64 as armv8-aes-asm.S and armv8-aes-asm_c.c, plus the aes.c callers and aes.h prototypes. The MASM twin is in https://github.com/wolfSSL/scripts/pull/670, which adds no callers, so this PR is what makes the routines reachable.
test.c gains a streaming case using multi-block chunks, checked against the one-shot result; the existing tests only ever pass one block, leaving the 4x path uncovered.
armv8-aes-asm_c.c also picks up 42 bcc/bcs → b.cc/b.cs at pre-existing sites: upstream's committed copy is stale against upstream's own generator. Same encodings, no behavior change.
Generator: wolfSSL/scripts#. Committed files reproduce byte-for-byte.
Note: the simultaneous-keys streaming test fails until J's key-schedule fix merges. Pre-existing, not from this PR.
Pairs with: https://github.com/wolfSSL/scripts/pull/674
Testing
emulated, baremetal and virtualized.
Checklist