Thread the caller's verify setting into trusted-peer loads and parse multi-valued RDNs

[julek-wolfssl]

• Pass the caller's effective verify setting, including
  WOLFSSL_LOAD_FLAG_DATE_ERR_OKAY -> VERIFY_SKIP_DATE, into the
  trusted-peer file, path and buffer loads instead of letting
  wolfSSL_CTX_trust_peer_cert() recompute it, so the flag reaches the
  trust-peer path. Skip the trusted-peer copy of a CA file when the CA
  load itself failed, matching the buffer and path loaders.

• Parse multi-valued RDNs, where one SET holds several
  AttributeTypeAndValues. RFC 5280 4.1.2.4 defines a
  RelativeDistinguishedName as SET SIZE (1..MAX) OF
  AttributeTypeAndValue, so the packed form is valid and was rejected.
  The loop is bounded by the SET's own length: an AttributeTypeAndValue
  outside the SET is rejected rather than folded into the preceding RDN,
  which would otherwise build a DN that a strict parser does not. The
  name NID is reset before each one so unknown OIDs are not filed under
  the previous entry.

• Fix the generated ACME identifier OID table, which put both entries in
  one arm of the sum scheme, breaking builds with WOLFSSL_ACME_OID.
  Regenerate it consistently with the other extension OIDs.

[Copilot]

🔵 Needs a closer look

src/ssl_load.c logs that a trusted-peer load error is ignored but still returns the failing status, creating an inconsistent/fragile return value.

Pull request overview

This PR improves wolfSSL’s OpenSSL-compatibility behavior in certificate loading and X.509 parsing by relaxing strict RFC checks to match what OpenSSL accepts, adding recognition for additional extensions/OIDs, and updating API tests accordingly.

Changes:

• Thread the effective verify mode (including skip-date) into trusted-peer certificate loading paths and avoid attempting trusted-peer loads when the CA load failed.
• Relax parsing/verification behavior to accept legacy certificates (tbs vs outer signatureAlgorithm mismatch, empty subjectAltName, multi-valued RDNs) and recognize/skip critical qcStatements.
• Regenerate/update OID sum definitions and add new regression tests covering the relaxed parsing cases and verify-flag behavior.

File summaries

File	Description
wolfssl/wolfcrypt/oid_sum.h	Adjusts extension OID sum entries (ACME identifier handling) and adds QC_STATEMENTS_OID.
wolfcrypt/src/asn.c	Implements relaxed parsing behaviors (multi-valued RDN, empty SAN, signatureAlgorithm mismatch) and skips critical qcStatements.
wolfcrypt/src/asn_orig.c	Mirrors relaxed SAN and signatureAlgorithm mismatch handling in the “orig” ASN parser.
src/ssl_load.c	Refactors trusted-peer loading helpers to accept caller-provided verify settings and threads skip-date through trusted-peer loads.
scripts/asn1_oid_sum.pl	Updates the OID-sum generator inputs for ACME identifier and qcStatements.
tests/api/test_certman.c	Adjusts cert manager expectations to reflect skip-date propagation into trusted-peer loads.
tests/api/test_asn.h	Registers new ASN parsing tests for the added compatibility behaviors.
tests/api/test_asn.c	Adds new fixtures/tests for signatureAlgorithm mismatch, empty SAN, multi-valued RDN, and critical qcStatements.
tests/api.c	Adds an API regression test asserting skip-date behavior is preserved when verify-peer is enabled.

Review details

Suppressed comments (1)

src/ssl_load.c:3175

• In wolfssl_ctx_load_path_file(), the trusted-peer load failure is logged as "Ignoring this error", but the function still returns that failing ret value. This makes the return value inconsistent with the intended behavior (CA load succeeded) and could cause false failure propagation if any caller starts using the return code more strictly.

        /* Try loading as a trusted peer certificate with the same
         * verification setting as the CA load. */
        ret = TrustPeerCertFile(ctx, name, WOLFSSL_FILETYPE_PEM, verify);
        if (ret != 1) {
            WOLFSSL_MSG("wolfSSL_CTX_trust_peer_cert error. "
                        "Ignoring this error.");
        }

• Files reviewed: 9/9 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

MemBrowse Memory Report

gcc-arm-cortex-m0plus

• FLASH: .text +96 B (+0.2%, 67,067 B / 262,144 B, total: 26% used)

gcc-arm-cortex-m3

• FLASH: .text +96 B (+0.1%, 125,883 B / 262,144 B, total: 48% used)

gcc-arm-cortex-m4

• FLASH: .text +64 B (+0.0%, 205,033 B / 262,144 B, total: 78% used)

gcc-arm-cortex-m4-baremetal

• FLASH: .text +64 B (+0.1%, 69,551 B / 262,144 B, total: 27% used)

gcc-arm-cortex-m4-crypto-only

• FLASH: .text +64 B (+0.0%, 178,980 B / 262,144 B, total: 68% used)

gcc-arm-cortex-m4-dtls13

• FLASH: .rodata +12 B, .text +64 B (+0.0%, 186,824 B / 1,048,576 B, total: 18% used)

gcc-arm-cortex-m4-min-ecc

• FLASH: .text +64 B (+0.1%, 64,401 B / 262,144 B, total: 25% used)

gcc-arm-cortex-m4-openssl-compat

• FLASH: .rodata +16 B, .text +128 B (+0.0%, 783,348 B / 1,048,576 B, total: 75% used)

gcc-arm-cortex-m4-pkcs7

• FLASH: .text +64 B (+0.0%, 217,704 B / 262,144 B, total: 83% used)

gcc-arm-cortex-m4-pq

• FLASH: .rodata +12 B, .text +64 B (+0.0%, 301,716 B / 1,048,576 B, total: 29% used)

gcc-arm-cortex-m4-rsa-only

• FLASH: .rodata +8 B, .text +64 B (+0.0%, 332,520 B / 1,048,576 B, total: 32% used)

gcc-arm-cortex-m4-sp-math

• FLASH: .text +64 B (+0.1%, 64,401 B / 262,144 B, total: 25% used)

gcc-arm-cortex-m4-tls12

• FLASH: .text +64 B (+0.1%, 126,655 B / 262,144 B, total: 48% used)

gcc-arm-cortex-m4-tls13

• FLASH: .text +128 B (+0.1%, 242,267 B / 262,144 B, total: 92% used)

gcc-arm-cortex-m7

• FLASH: .text +64 B (+0.0%, 205,033 B / 262,144 B, total: 78% used)

gcc-arm-cortex-m7-pq

• FLASH: .rodata +12 B, .text +64 B (+0.0%, 302,676 B / 1,048,576 B, total: 29% used)

gcc-arm-cortex-m7-tls13

• FLASH: .text +128 B (+0.1%, 242,331 B / 262,144 B, total: 92% used)

linuxkm-standard

• Data: __patchable_function_entries +16 B (+0.0%, 49,816 B)

stm32-sim-stm32h753

• FLASH: .text +1,228 B (+0.7%, 189,808 B / 2,097,152 B, total: 9% used)
  No memory changes detected for:
• linuxkm-pie

[Copilot]

🟡 Changes recommended

Multi-valued RDN SET membership is lost during decode/re-encode, changing the distinguished name.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

wolfcrypt/src/asn.c:15629

• Using complete = 0 also stops GetASN_Items() from verifying that the first AttributeTypeAndValue SEQUENCE was fully consumed. A malformed SET whose first SEQUENCE contains one valid OID/value followed by another valid AVA SEQUENCE is therefore accepted: the inner trailing SEQUENCE is parsed by the new loop as if it were a sibling AVA. Check the parsed index against the first SEQUENCE's end before entering the SET-level loop (and add this nested-AVA case to the negative test).

• Files reviewed: 9/9 changed files
• Comments generated: 1
• Review effort level: Balanced