Rust wrapper: Remove unused aes_cts cfg detection - #11402
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Conversation
Fixes F-8294.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The removed cfg (aes_cts) is not used anywhere in the Rust wrapper sources, so this is a safe dead-code cleanup with no behavioral impact.
Pull request overview
This PR simplifies the Rust wolfcrypt wrapper build script by removing cfg auto-detection for AES-CTS, which is not referenced anywhere in the Rust wrapper code and therefore never affected compilation output.
Changes:
- Removed
wc_AesCtsEncrypt-based cfg probing (aes_cts) fromscan_cfg()in the Rust wrapper build script.
File summaries
| File | Description |
|---|---|
| wrapper/rust/wolfssl-wolfcrypt/build.rs | Drops unused AES-CTS cfg detection to reduce build-script surface area and unnecessary cfg emission. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
retest this please ([Checks API] No suitable checks publisher found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: Remove unused aes_cts cfg detection
Fixes F-8294.
Testing
How did you test?
Checklist