Repository navigation
20261029-misc-fixes - #11934
20261029-misc-fixes#11934douzzer wants to merge 4 commits into
Conversation
|
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved issues include out-of-bounds authentication-tag zeroization, broken kernel return-thunk mitigation handling, and compilation failures in supported configurations.
4 open issues
What changed in this PR
This PR addresses compatibility and cleanup issues in wolfSSL’s Linux kernel integration, AES-GCM shim, and cryptographic tests and benchmarks.
Changes:
- Correct kernel mitigation flag handling and adjust objtool controls.
- Add ciphertext and tag wiping on AES-GCM shim failures.
- Refactor FrodoKEM benchmark key lifetimes and exclude SLH-DSA certificate tests from no-malloc builds.
| File | Description |
|---|---|
wolfssl/wolfcrypt/wc_compat.h |
Wipe output and authentication tags after streaming-shim failures. |
wolfcrypt/test/test.c |
Disable SLH-DSA certificate tests with WOLFSSL_NO_MALLOC. |
wolfcrypt/benchmark/benchmark.c |
Adjust FrodoKEM key initialization, generation, and cleanup. |
linuxkm/Kbuild |
Update mitigation flags, legacy configuration aliases, and objtool handling. |
Review effort: Balanced
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11934
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): linuxkm/Kbuild, wolfcrypt/benchmark/benchmark.c
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
CONFIG_MITIGATION_RETHUNK, and CONFIG_OBJTOOL; use inline/kept thunks and globally disable objtool wherever needed and not otherwise; accommodate/error for clang as needed. Note this fixes a preexisting swap flub re RETPOLINE and RETHUNK. Also tabify some whitespace.
bench_frodokem_keygen(), bench_frodokem_encap(), and bench_frodokem(), to fix uninited-key free ops. Also initialize devIds in bench_frodokem().
wc_AesGcmEncrypt_compat_shim(), wipe tag and output to match wc_AesGcmEncrypt() (ISO-19790).
…LLOC (not compatible).
b5c5eb4 to
36f4ff4
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The new inline shims call ForceZero without a prior declaration when FIPS AES-GCM and WOLFSSL_NO_FORCE_ZERO are enabled, causing compilation failures even when applications provide the zeroizer in another translation unit.
3 resolved since last review
Review effort: Balanced
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11934
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): linuxkm/Kbuild, wolfcrypt/benchmark/benchmark.c
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: wolfssl/wolfcrypt/memory.h
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
|
retest this please |
|
retest this please ( |
linuxkm/Kbuild: fix+improve handling forCONFIG_MITIGATION_RETPOLINE,CONFIG_MITIGATION_RETHUNK, andCONFIG_OBJTOOL. Also tabify some whitespace.wolfssl/wolfcrypt/wc_compat.h: inwc_AesGcmEncrypt_compat_shim(), wipe tag and output to matchwc_AesGcmEncrypt().wolfcrypt/test/test.c: don't defineSLHDSA_TEST_CERTifWOLFSSL_NO_MALLOC(not compatible).wolfcrypt/benchmark/benchmark.c: refactor key init/free inbench_frodokem_keygen(),bench_frodokem_encap(), andbench_frodokem(), to fix uninited-key free ops.