Skip to content

tests: gate test_wolfSSL_X509_check_email_san on no time. - #11950

Merged
douzzer merged 1 commit into
wolfSSL:masterfrom
philljj:fix-all-no-time
Oct 30, 2026
Merged

douzzer merged 1 commit into
wolfSSL:masterfrom
philljj:fix-all-no-time

Conversation

@philljj

@philljj philljj commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

Gate test_wolfSSL_X509_check_email_san on no time.

Test was failing with NOT_COMPILED_IN in when built with no asn time.

./configure --enable-static --disable-shared --enable-debug \
  --enable-all CFLAGS=-DNO_ASN_TIME && \
  make && \
  ./tests/unit.test -test_wolfSSL_X509_check_email_san

found while testing:

@philljj philljj self-assigned this Oct 30, 2026
Copilot AI balanced review requested due to automatic review settings October 30, 2026 21:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the email SAN test and helper guard changes.

No open issues 🎉

What changed in this PR

This PR addresses an X.509 email SAN test failure in builds without ASN time support, following regression testing in #11936.

Changes:

  • Skip test_wolfSSL_X509_check_email_san when NO_ASN_TIME or USER_TIME is defined.
  • Apply the same guards to its certificate-generation helper.
File Description
tests/​api/​test_ossl_x509.c Add matching time-feature guards to the email SAN test and its helper.

Review effort: Balanced

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

@philljj philljj assigned wolfSSL-Bot and unassigned philljj Oct 30, 2026
@douzzer
douzzer merged commit 1c7845c into wolfSSL:master Oct 30, 2026
418 checks passed
@philljj
philljj deleted the fix-all-no-time branch October 30, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants