Repository navigation
Conversation
Rethrow the WorkOS SDK's ApiKeyRequiredException instead of swallowing it to null, and let the impersonation banner degrade when the action rejects.
Wrap the WorkOS SDK's ApiKeyRequiredException in an error naming WORKOS_API_KEY. The impersonation banner logs the rejection and renders without the organization name instead of leaving an unhandled rejection.
[Medium impact] The changes appear safe to merge; no new actionable issues were found. SummaryThe PR documents keyless sign-in, adds tests for this package’s keyless paths, and gives organization lookups a clear missing-key error.
Reviews (3) · Last reviewed commit: "docs: drop the expected-release note fro..." · Reviewed by Greptile |
A lookup for a previous organization that settles after the organization changed no longer overwrites the current name.
⚓ Shipyard review suggestionSuggested team: applied-ai, based on recent contributors to the changed files (@mitch-fultz).
Links open Shipyard for confirmation. Choosing a reviewer overrides availability; “Pick for me” skips known absences. Shipyard Analysis⏳ Generating analysis... ⚓ Explore the analysis in depth in Shipyard · 🔄 Re-run analysis |
gjtorikian
left a comment
There was a problem hiding this comment.
LGTM. Will need authkit-session #59 to merge and 0.8.0 to publish
| ### Public client (keyless) mode | ||
|
|
||
| > [!IMPORTANT] | ||
| > Keyless mode needs `@workos/authkit-session` 0.8.0 or later (expected to be the first release with [workos/authkit-session#59](https://github.com/workos/authkit-session/pull/59)). With earlier versions, startup validation still reports `WORKOS_API_KEY is required`. |
There was a problem hiding this comment.
no need for "expected to be..."
There was a problem hiding this comment.
Dropped the "expected to be…" parenthetical; the note now just says keyless mode needs @workos/authkit-session 0.8.0 or later.
Bring keyless PKCE public clients to @workos/authkit-tanstack-react-start, the same experience as workos/authkit-react-router#96 (workos/authkit-react-router#96). It builds on the authkit-session change from the preceding job, whose branch and PR it names.
authkit-tanstack-start delegates to @workos/authkit-session (
src/server/authkit-loader.tscallscreateAuthServiceandgetConfig). So:riker/<n>-let-workos-authkit-session-run-as-a-keyle…or ask), via a pnpm override in this worktree only while developing. Never commit a file:, link: or override dependency.validateConfig, middleware options, anyconfigure/options types re-exported from authkit-session, and anything here that assumes an API key. Key-only features must surface authkit-session's clear error.example/: copy it to a scratch directory, point it at both packed builds (authkit-session and this package), run it with no WORKOS_API_KEY, and show the sign-in route redirects withcode_challengeand S256. Leave the dev server running and give Nick the URL and steps to sign in, see the session load, and see a refresh succeed.@workos/authkit-sessionrange. Say exactly which authkit-session release this needs, and whether the PR can merge before that release (e.g. if nothing here type-depends on the new union, it can; otherwise note that it must wait and bump the range when it's out).Riker's check
pnpm install --frozen-lockfile >/dev/null && git diff --quiet origin/main...HEAD -- pnpm-lock.yaml && ! grep -qE '"(file|link):' package.json example/package.json && pnpm typecheck && pnpm lint && pnpm format:check && pnpm test && pnpm buildpassed.Opened as a draft by Riker (job 98).