Repository navigation
Conversation
…er agent Since Agent SDK 0.2.89, omitting settingSources loads every settings source, including ~/.claude. The installer never set it, so its agent loaded the user's plugins, MCP servers, hooks, CLAUDE.md memory, and permission rules. Allow rules apply before installerCanUseTool, so a user rule could bypass the installer's Bash restrictions, and the agent could read the user's MCP servers and memory. Set settingSources: [] so the agent loads only the WorkOS skills plugin and Claude Code's built-ins, and strictMcpConfig: true so no MCP server loads unless the installer passes it, even if the SDK's defaults change again.
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe installer now passes
Reviews (1) · Last reviewed commit: "fix(installer): stop loading user Claude..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The installer's Claude agent now loads none of the user's Claude Code configuration.
settingSources: []: no~/.claude, project, or local settings.strictMcpConfig: true: no MCP server loads unless the installer passes it (it passes none). This guards against the SDK changing its defaults again.Why
The installer never set
settingSources. Up to Agent SDK 0.2.87, omitting it meant isolation. Since 0.2.89 (2026-03-31), it loads every source, including~/.claude. As a result, the installer agent got the user's plugins, MCP servers, hooks,CLAUDE.mdmemory, and permission rules.installerCanUseTool, so a user rule such asBash(curl:*)got past the installer's Bash restrictions.Exposure:
~0.2.x, so fresh installs resolved SDK ≥ 0.2.89.Verification
The SDK's startup message, with the same options as the installer and a real
~/.claudesetup:workos+ Claude Code's 4 built-insworkos:workos,workos:workos-widgets).bun run testpasses (3,477), and typecheck, lint, format, and build are clean.#266 contains the same
settingSourceschange and will be rebased onto this.