feat(generated): Pipes (batch 8ad8e447) - #438
Conversation
Greptile SummaryThis PR regenerates the Pipes SDK surface to support selecting among multiple connected accounts and exposes the account collection on provider-list responses. The generated update path currently drops that selector, and insertion of the new optional arguments changes existing positional RequestOptions slots.
Confidence Score: 3/5This PR is not safe to merge until the update operation forwards its connected-account selector and existing positional RequestOptions calls remain compatible. Two public request paths can fail: positional callers may receive a TypeError after the parameter insertion, and update callers cannot transmit the newly accepted account selector. Files Needing Attention: lib/Service/Pipes.php Important Files Changed
|
| string $provider, | ||
| string $userId, | ||
| ?string $organizationId = null, | ||
| ?string $connectedAccountId = null, | ||
| ?\WorkOS\RequestOptions $options = null, |
There was a problem hiding this comment.
If existing clients pass RequestOptions positionally, inserting $connectedAccountId before $options binds that object to a ?string parameter. Because strict types are enabled, calls such as getAccessToken($provider, $userId, null, $options) now throw a TypeError. The same breaking change affects all five modified public Pipes methods.
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/Service/Pipes.php
Line: 333-337
Comment:
**Positional Calls Now Fail**
If existing clients pass `RequestOptions` positionally, inserting `$connectedAccountId` before `$options` binds that object to a `?string` parameter. Because strict types are enabled, calls such as `getAccessToken($provider, $userId, null, $options)` now throw a `TypeError`. The same breaking change affects all five modified public Pipes methods.
**Knowledge Base Used:**
- [Application and data integrations](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/integrations.md)
- [Connect and data integrations](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/connect-and-data-integrations.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| ?array $scopes = null, | ||
| ?\WorkOS\Resource\PipeConnectedAccountState $state = null, | ||
| ?string $organizationId = null, | ||
| ?string $connectedAccountId = null, |
There was a problem hiding this comment.
updateUserConnectedAccount accepts $connectedAccountId but sends it in neither the PUT body nor the query, unlike the matching get and delete operations. When a user has multiple accounts for a provider, the API cannot select the requested account and may reject the ambiguous update or modify the legacy/default account instead.
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/Service/Pipes.php
Line: 448-451
Comment:
**Update Drops Account Selector**
`updateUserConnectedAccount` accepts `$connectedAccountId` but sends it in neither the PUT body nor the query, unlike the matching get and delete operations. When a user has multiple accounts for a provider, the API cannot select the requested account and may reject the ambiguous update or modify the legacy/default account instead.
**Knowledge Base Used:**
- [Application and data integrations](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/integrations.md)
- [Connect and data integrations](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/connect-and-data-integrations.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
Regenerated SDK from spec changes.
Triggered by workos/openapi-spec@b110a04