Skip to content

feat(generated): Pipes (batch 8ad8e447) - #438

Merged
workos-sdk-automation[bot] merged 2 commits into
mainfrom
oagen/batch-8ad8e447
Sep 5, 2026
Merged

feat(generated): Pipes (batch 8ad8e447)#438
workos-sdk-automation[bot] merged 2 commits into
mainfrom
oagen/batch-8ad8e447

Conversation

@workos-sdk-automation

Copy link
Copy Markdown
Contributor

Summary

Regenerated SDK from spec changes.

Triggered by workos/openapi-spec@b110a04

@workos-sdk-automation workos-sdk-automation Bot added the autogenerated Autogenerated code or content label Sep 5, 2026
@workos-sdk-automation
workos-sdk-automation Bot requested review from a team as code owners September 5, 2026 15:37
@workos-sdk-automation workos-sdk-automation Bot added the autogenerated Autogenerated code or content label Sep 5, 2026
@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR regenerates the Pipes SDK surface to support selecting among multiple connected accounts and exposes the account collection on provider-list responses. The generated update path currently drops that selector, and insertion of the new optional arguments changes existing positional RequestOptions slots.

  • Adds connected_account_id to credential and token request resources.
  • Adds connected-account selection to five Pipes service methods.
  • Adds connected_accounts to the provider-list response model and fixtures.
  • Updates generated synchronization and changelog metadata.

Confidence Score: 3/5

This PR is not safe to merge until the update operation forwards its connected-account selector and existing positional RequestOptions calls remain compatible.

Two public request paths can fail: positional callers may receive a TypeError after the parameter insertion, and update callers cannot transmit the newly accepted account selector.

Files Needing Attention: lib/Service/Pipes.php

Important Files Changed

Filename Overview
lib/Service/Pipes.php Adds connected-account selectors to public operations, but breaks positional RequestOptions compatibility and fails to forward the selector from the update operation.
lib/Resource/DataIntegrationsListResponseData.php Adds typed hydration and serialization for the connected-account collection; no confirmed defect remains.
lib/Resource/DataIntegrationsGetUserTokenRequest.php Correctly adds optional connected-account selection to token request hydration and serialization.
lib/Resource/DataIntegrationsVendCredentialsRequest.php Correctly adds optional connected-account selection to credential request hydration and serialization.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  App[PHP application] --> Pipes[Pipes service]
  Pipes -->|credential/token body| Selector[connected_account_id]
  Pipes -->|get/delete query| Selector
  Pipes -->|update currently omits selector| Missing[Ambiguous update request]
  Selector --> API[WorkOS API]
  Missing --> API
Loading
Prompt To Fix All With AI
### Issue 1
lib/Service/Pipes.php:333-337
**Positional Calls Now Fail**

If existing clients pass `RequestOptions` positionally, inserting `$connectedAccountId` before `$options` binds that object to a `?string` parameter. Because strict types are enabled, calls such as `getAccessToken($provider, $userId, null, $options)` now throw a `TypeError`. The same breaking change affects all five modified public Pipes methods.

### Issue 2
lib/Service/Pipes.php:448-451
**Update Drops Account Selector**

`updateUserConnectedAccount` accepts `$connectedAccountId` but sends it in neither the PUT body nor the query, unlike the matching get and delete operations. When a user has multiple accounts for a provider, the API cannot select the requested account and may reject the ambiguous update or modify the legacy/default account instead.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "chore(generated): add release notes frag..." | Re-trigger Greptile

Comment thread lib/Service/Pipes.php
Comment on lines 333 to 337
string $provider,
string $userId,
?string $organizationId = null,
?string $connectedAccountId = null,
?\WorkOS\RequestOptions $options = null,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Positional Calls Now Fail

If existing clients pass RequestOptions positionally, inserting $connectedAccountId before $options binds that object to a ?string parameter. Because strict types are enabled, calls such as getAccessToken($provider, $userId, null, $options) now throw a TypeError. The same breaking change affects all five modified public Pipes methods.

Knowledge Base Used:

Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/Service/Pipes.php
Line: 333-337

Comment:
**Positional Calls Now Fail**

If existing clients pass `RequestOptions` positionally, inserting `$connectedAccountId` before `$options` binds that object to a `?string` parameter. Because strict types are enabled, calls such as `getAccessToken($provider, $userId, null, $options)` now throw a `TypeError`. The same breaking change affects all five modified public Pipes methods.

**Knowledge Base Used:**
- [Application and data integrations](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/integrations.md)
- [Connect and data integrations](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/connect-and-data-integrations.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Comment thread lib/Service/Pipes.php
Comment on lines 448 to +451
?array $scopes = null,
?\WorkOS\Resource\PipeConnectedAccountState $state = null,
?string $organizationId = null,
?string $connectedAccountId = null,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Update Drops Account Selector

updateUserConnectedAccount accepts $connectedAccountId but sends it in neither the PUT body nor the query, unlike the matching get and delete operations. When a user has multiple accounts for a provider, the API cannot select the requested account and may reject the ambiguous update or modify the legacy/default account instead.

Knowledge Base Used:

Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/Service/Pipes.php
Line: 448-451

Comment:
**Update Drops Account Selector**

`updateUserConnectedAccount` accepts `$connectedAccountId` but sends it in neither the PUT body nor the query, unlike the matching get and delete operations. When a user has multiple accounts for a provider, the API cannot select the requested account and may reject the ambiguous update or modify the legacy/default account instead.

**Knowledge Base Used:**
- [Application and data integrations](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/integrations.md)
- [Connect and data integrations](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/connect-and-data-integrations.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

@workos-sdk-automation
workos-sdk-automation Bot merged commit 42d6bb1 into main Sep 5, 2026
9 checks passed
@workos-sdk-automation
workos-sdk-automation Bot deleted the oagen/batch-8ad8e447 branch September 5, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autogenerated Autogenerated code or content

Development

Successfully merging this pull request may close these issues.

0 participants