Skip to content

Avoid global_terms_enabled() deprecation notice in wp site empty #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r4sky0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid global_terms_enabled() deprecation notice in wp site empty #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions features/site-empty.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,14 @@ Feature: Empty a WordPress site of its data

When I run `wp --url=example.com/foo post list --format=ids`
Then STDOUT should be empty

@require-wp-6.1
Scenario: Empty a multisite site without deprecation notices
Given a WP multisite installation
And I run `wp config set WP_DEBUG true --raw`

When I run `wp site empty --yes`
Then STDERR should not contain:
"""
global_terms_enabled
"""
3 changes: 2 additions & 1 deletion src/Site_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,9 @@ private function insert_default_terms() {
/* translators: Default category slug */
$cat_slug = sanitize_title( _x( 'Uncategorized', 'Default category slug' ) );

// global_terms_enabled() is deprecated since WP 6.1, where global terms are always off.
// @phpstan-ignore function.deprecated
Comment thread
swissspidy marked this conversation as resolved.
if ( global_terms_enabled() ) { // phpcs:ignore WordPress.WP.DeprecatedFunctions.global_terms_enabledFound -- Required for backwards compatibility.
if ( Utils\wp_version_compare( '6.1', '<' ) && global_terms_enabled() ) { // phpcs:ignore WordPress.WP.DeprecatedFunctions.global_terms_enabledFound -- Required for backwards compatibility.
$cat_id = $wpdb->get_var( $wpdb->prepare( "SELECT cat_ID FROM {$wpdb->sitecategories} WHERE category_nicename = %s", $cat_slug ) );
if ( null === $cat_id ) {
$wpdb->insert(
Expand Down
Loading