Repository navigation
fix(faustwp): stop passing null to preg_match when a front-end URL is missing - #2701
Open
josephfusco wants to merge 4 commits into
Open
josephfusco wants to merge 4 commits into
josephfusco wants to merge 4 commits into
Conversation
josephfusco
added
[Type] Bug
josephfusco
marked this pull request as ready for review
October 23, 2026 17:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #2700
A null front-end URL is still rejected and keeps the saved one, exactly as before, just without the PHP 8.1+ deprecation notice; the test-only
$serverproperty declaration clears the other notice, and the plugin tests now fail on any PHP deprecation instead of just printing it; they pass on WordPress 7.1 with PHP 8.5 and 6.8 with PHP 8.2, and fail with the original fix reverted.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with tracing the deprecation notices from the plugin tests and fixing them without changing behavior.