Conversation
AMO returns `null` instead of a locale map when a listing leaves the description or summary empty, so `Object.values` threw and the whole addon resolved to `null` in GraphQL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ePekSUNprhYv49RLVbznD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullinstead of a locale map when a listing leaves the description or summary empty.Object.values(null)threw, so the resolver returnednullfor the whole addon and it disappeared from the wxt.dev showcase (it hit 2 of the 73 showcase Firefox slugs, and TabWatch before its listing got a description)."", which keepslongDescription/shortDescriptionvalid for the non-null GraphQL schema. Addedfirefox-api.test.tscovering both the normal and null cases.ratings,current_version) can also be null and still nulls the addon; that's no worse than today and is outside this fix.chrome-crawler.e2e.test.tsfails locally onmainas well (it crawls the live Chrome Web Store), so it's unrelated to this change.🤖 Generated with Claude Code
https://claude.ai/code/session_015ePekSUNprhYv49RLVbznD