Stop Thunder from serving retweets of tombstoned originals - #150
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Stop Thunder from serving retweets of tombstoned originals#150Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
mark_as_deleted removes the original CompactPost and tombstones its id. Retweets of that id stay on the retweeter deque, so Following / For You in-network kept serving a deleted post as a retweet card. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mark_as_deletedtombstones the original and drops its CompactPost; retweets of that id stay on the retweeter deque.get_posts_from_mapnever checkeddeleted_postsforsource_post_id, so a deleted in-network post kept serving as a retweet card.Skip retweets whose source id is tombstoned. Live-source retweets are unchanged. Not #57 (sibling eviction), #59 (deque strip), or #138 (QuotedTweetDeleteEvent).
Test: delete original 100, retweet 200 is gone, retweet 201 of live 101 still serves. Standalone predicate 4/4.
thunder/ has no Cargo.toml in this snapshot.