Stop Latest Following from ignoring hide-replies and hide-links - #152
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Conversation
QueryBuilder copied exclude_videos but never hide_replies / hide_links / exclude_replies / exclude_retweets. Night Owl always include:retweets and never applied -filter:replies or -filter:links, so those viewer preferences were a no-op on Latest Following. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Latest Following copies
exclude_videos(#120) and still ignores the rest of the viewer content-controls.QueryBuilder never copied
hide_replies/hide_links/exclude_replies/exclude_retweets. Night Owl always searched withinclude:retweetsand never applied-filter:repliesor-filter:links. Reverse-chron filters were RT-dedup, muted keyword, and self-reply. Hide-replies and hide-links were a no-op.Ranked Following / For You already have
VideoFilterfor hide-videos. They had no reply/link/retweet content-control filter either; the same mixer filter is wired next toVideoFilter.This is not #120 (hide-videos / MediaInfo). Not #98 (quoted video duration). Not #99 / #132 (self-reply chains).
Five-line proof
QueryBuilder(server.rs) and Night Owlold_query(following_night_owl_source.rs)FollowingContentControlsFilteronReverseChronPostsPipeline(and Phoenix next toVideoFilter)include:retweetsexclude_videosis already copied andVideoFilteralready exists (Stop Latest Following from ignoring hide-videos #120)Change
hide_replies,hide_links,exclude_replies,exclude_retweetsontoScoredPostsQuery-filter:replies,-filter:links, and-filter:nativeretweetswhen those flags are setTests
www.host, keepsnotwwwinclude:retweets; flags composeStandalone decision-table harness (same match arms): 19/19 passed.
cargo testcannot run. Public dump has no Home Mixer manifest.Leftover
For You cached-posts Redis key still keys only on
exclude_videos. A cache hit can still contain replies/links; the new Phoenix filter drops them after the hit (slate may underfill). Same class as #98 leftover for quoted duration on cache.Fork PR: none