Stop InNetwork from copying a join_all OON stamp after TES fills author_id - #154
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Conversation
…or_id. run_hydrators hydrates every hydrator from one snapshot, then applies writes in vec order. Reordering CoreData before InNetwork does not change what hydrate sees. Stamp in_network from the live author_id on write-back. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
run_hydratorsjoin_alls every hydrator against the source snapshot, then applies writes in vec order. InNetwork.hydrate reads TweetMixerauthor_id = 0and stampsin_network = Some(false). CoreData.update then fills the TES author. Copying the snapshot stamp keeps OON.#128 only reorders the vec. That does not change what hydrate sees. VF then fetches at TimelineHomeRecommendations. Recs-only Drop fires (DO_NOT_AMPLIFY, NSFW_HIGH_RECALL, SPAM_HIGH_RECALL, MALICIOUS_URL). The same followee on Home is Allow.
InNetworkCandidateHydrator(hydratesnapshot +updatecopy) viacandidate_pipeline.rsjoin_allVFCandidateHydrator(in_network.unwrap_or(false)→ Recs) thenVFFilterapply_hydrationrestamps from the liveauthor_idafter CoreData.update. Genuine unfollowed authors stay OON.Fix
Override
apply_hydrationto stamp fromcandidate.author_idafter CoreData.update. Keep CoreData before InNetwork so the write-back sees the TES author.Tests
Standalone join_all model: 6/6 passed.
cargo testcannot run. Public dump has no Home Mixer / candidate-pipeline manifest.Survey claimed
#128 (vec order). #135 (cache enable). #131 (TES overwrite). #132 (NightOwl already_hydrated). #129 / #141 (exclusive). Not those.
Fork PR: none