Stop SubscriptionHydrator from skipping exclusive ids on retweets - #155
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Conversation
TES exclusive lookup and the hydrator cache were keyed by the wrapper tweet_id. A retweet of a Super Follow post therefore looked like a public tweet, and IneligibleSubscriptionFilter kept it. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phoenix
SubscriptionHydratorasks TES for exclusive authors by wrappertweet_id. Super Follow lives on the original. A retweet wrapper is not exclusive, sosubscription_author_idstays None andIneligibleSubscriptionFilterkeeps the card.SubscriptionHydrator(phoenix_candidate_pipeline.rs)IneligibleSubscriptionFilterkeepssubscription_author_id: Noneas publiccandidate.tweet_idinstead ofget_original_tweet_id()MediaInfoHydrator,LanguageCodeHydrator,EngagementCountsHydratoralready fetch by original; QuoteHydrator is Stop QuoteHydrator from skipping quoted ids on retweets #118This is not #118 (quoted ids). This is not #129 (subscription-list miss). This is not #141 (TES fail-closed).
Look up and cache TES exclusive authors by
candidate.get_original_tweet_id(). Native exclusive posts are unchanged. Two retweets of the same exclusive now share the cache key.cargo testcannot run. Public dump has no Home Mixer manifest.Fork PR: none
Survey: #96–#142. Unclaimed.