scarecrow: write NSFW_CARD_IMAGE URL verdicts from Grok media_update - #166
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Conversation
Bot 24493 is named To_URL_Verdict and already loads share ids via GetGrokShareIdsFromGrokMediaId, but it only SetLabelWithTtl on GrokMediaNsfwDetection. The sole URL writer is bot 24603, which runs on grok_share and requires that label to already exist. When the share mapping is populated at media_update time, grok_share has already fired without the label and will not fire again. No NSFW_CARD_IMAGE PUT is written, so bot 7413 never interstitials tweets that embed the Grok share URL. Write the verdict from the share ids 24493 already fetched, matching card-image bot 7429 and share bot 24603. The media label is unchanged so the score-then-share path still works. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bot 24493 (
NSFW_Grok_Generated_Image_To_URL_Verdict) scores Grok-generated images onmedia_updateand is the only bot that looks up existing Grok share ids. It never writes a URL verdict.The only writer is bot 24603 (
NSFW_Grok_Share). That bot runs ongrok_shareand requiresGrokMediaNsfwDetectionto already exist. When the share mapping is populated atmedia_updatetime,grok_sharehas already fired without the label and will not fire again.No
NSFW_CARD_IMAGEPUT is written. Bot 7413 therefore never applies tweet interstitials to posts that embedhttps://x.com/i/grok/share/{id}. Card-image bot 7429 writes the verdict directly frommedia_update; the Grok path does not.Proof
:grok_share_ids = GetGrokShareIdsFromGrokMediaId(entityId)and only logs them.SetLabelWithTtl("GrokMediaNsfwDetection", …)and returns. There is noWriteUrlVerdictsV2.GetLabel("GrokMediaNsfwDetection", …) != ""ongrok_share.url_reputation_changePUT ofNSFW_CARD_IMAGE. That PUT never occurs.Change
After setting the media label, write
NSFW_CARD_IMAGEfor each already-mapped share URL, matching 7429 and 24603 (7-day TTL, skip if the verdict is alreadyNSFW_CARD_IMAGEorBAD). The media label is unchanged, so the score-then-share path still works.Tests
These bots run inside Botmaker against internal Strato. There is no in-repo harness. Correctness is the event-order split plus the write that 24493 already had the inputs for.
NSFW_CARD_IMAGE/BAD)Not a sibling of #104 (7429 DELETE cleanup) or #107 (
GetTweetLabelInfoFromURLRTF-read fail-open). Different bots, different event, missing write rather than unreachable delete.Fork PR: none