Stop Phoenix authorIsNsfwSeq from skipping retweets - #191
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Stop Phoenix authorIsNsfwSeq from skipping retweets#191Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
as_tweet_info zeroed safety_label_mask on every retweet, so Phoenix hashed the origin author with authorIsNsfwSeq=0. Gizmoduck already fetched the origin user but wrote the retweeter's NSFW bit. Stamp nsfw_author_phoenix from the origin on retweets and drop the retweet skip in as_tweet_info. Filter/ads poster bits are unchanged.
Pitchfork-and-Torch
force-pushed
the
cursor/magellan-overnight-b-nsfw-9cba
branch
from
September 8, 2026 23:06
88e7e0a to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phoenix hashes get_original_author_id() but as_tweet_info zeroed safety_label_mask on every retweet. Gizmoduck already fetched the origin user and then wrote the retweeter's NSFW bit into nsfw_author_phoenix. Training reads safetyLabelMaskSeq bit 2; serving therefore scored every RT of an NSFW original as a clean-author post.
Proof
This is not #125 (size residual, quoted OR, gizmoduck fail-closed). Not #185 (OON NSFW pre-score filter). Not #172/#188 (diversity/MoE retweeter key). Not #173 (safemodel tweet labels). Not #189 (DedupConversationFilter). Filter and ads poster bits are unchanged.
Fix
Tests cover origin-NSFW RT stamp, retweeter-NSFW clean-origin no stamp, and original-post unchanged.
cargo test cannot run home-mixer. Public dump has no Home Mixer manifest. Standalone rustc model of old vs new stamp: 5/5 passed.
Fork PR: none