Repository navigation
Use monotonic time and the configured interval for spinner pacing - #101
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spinner redraws stop when the system clock moves backwards because pacing uses
time.time().Spinner(interval=0.7).sleep()also sleeps the fixed default 0.2 seconds instead of the configured interval.Use the existing compatibility monotonic clock for elapsed time, allow an immediate initial redraw even at clock zero, and sleep for the configured interval. Deterministic tests simulate a backward wall-clock correction and verify redraw boundaries and sleep duration.
Validation: both new regression tests fail on the original code. Python 3.12: 65 passed, with the same six pre-existing Windows failures as the rerun baseline (63 passed). Four spinner tests pass on Python 3.10. No new Flake8 findings versus baseline;
git diff --checkpasses.AI assistance: OpenAI Codex (GPT-6). Original user request:
new 14ta koro aro(make 14 more new contributions). Diff inspection was automated; no human review or personal production usage is claimed.