Repository navigation
Scope HTML link text capture to each anchor - #93
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTMLConverter retains link_url after an anchor closes, so later ordinary text skips the callback. It also overwrites link_text for each data fragment, causing duplicate URL rendering when a link label spans nested tags. Empty anchors can reuse stale text or raise TypeError.
Initialize capture per anchor, accumulate all its text fragments and clear capture when it closes. Skip URL rendering for anchors without a URL. Regressions cover callback resumption, nested labels that equal the destination, consecutive and empty anchors, and unmatched closing tags. All three new tests fail against original master (2 failures, 1 error).
Python 3.12: all three new tests plus existing HTML conversion test pass; the same six anchor assertions pass independently on Python 3.10. Flake8 and diff checks pass. The full 72-test unittest run has the same six existing failure/error cases as pristine master's 69-test run in this Windows environment (HOME/path checks, terminal/CLI capture and MockedProgram). No clean full suite or historical Python 2.7-3.9 matrix is claimed.
Prepared with OpenAI Codex (GPT-6) assistance for
new 10ta koro(make 10 new contributions). No personal production usage or human code review is claimed.