Repository navigation
Keep key comparisons and ordering operations case insensitive - #99
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CaseInsensitiveKey("A") == "a"andCaseInsensitiveKey("A") != "a"are currently both true.CaseInsensitiveDict.move_to_end()also bypasses key coercion, so moving an existing key using another case raisesKeyError.Define inequality from the existing equality comparison (preserving
NotImplemented), and coerce keys for the inherited ordering operation. Tests cover operand direction, unsupported types, both ordering directions, non-string keys and missing keys.Validation: both new tests fail before the change. Python 3.12: 65 passed, with the same six pre-existing Windows failures as an independently rerun baseline (63 passed). Four case tests pass on Python 3.10. Flake8 passes with existing D211/D400 findings excluded;
git diff --checkpasses. The existing pop/update errors covered by #96 are outside this change.AI assistance: OpenAI Codex (GPT-6). Original user request:
new 14ta koro aro(make 14 more new contributions). Diff inspection was automated; no human review or personal production usage is claimed.