Fix neon64/swizzle on MSVC. - #1410
Open
degasus wants to merge 1 commit into
Open
Conversation
vreinterpretq is a no-op here, not even converting the type. As we provide the batch into vreinterpretq, we keep its strong typing and on return, CL tells me that it cannot convert to the output type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vreinterpretq is a no-op here, not even converting the type. As we provide the batch into vreinterpretq, we keep its strong typing and on return, CL tells me that it cannot convert to the output type.
Please don't treat this is high quality code - more as a bug report - even if it fix compiling my kernels.
After looking at this code for roughly 30 minutes, I assume a real fix might be to encapsulate all vreinterpretq calls into something strongly typed, even if this sounds annoying.
I actually wonder, is there a test which checks if swizzle compiles?