Repository navigation
Run the environment doctor after setup - #1297
Merged
Merged
Conversation
Contributor
|
@isaaclimmy is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @isaaclimmy, your first PR on Fair Code, that's awesome, thank you. This project is about making AI more accountable, and contributions like yours are what keep that work going. We'll review your changes shortly. If you haven't already, give the contributing guide a quick read: it covers how audits are structured and what we look for in a review. And if you're finding Fair Code useful or interesting, a star on the repo genuinely helps more people find it - no pressure, just appreciated. |
|
@yakew7 @propcgamer20-png - new PR touching a path you own, please review. |
yakew7
added a commit
that referenced
this pull request
Nov 8, 2026
Both entries were started with check_contributors.py --stub --commits (snapshot moved to PR #1298, commit counts from the contributors graph) and their TODO sentences replaced: the configurable GitHub CLI timeout (#1295) and the doctor after setup and the deferred xdist probe (#1297, #1298). Identity map rows for Alden and Isaac Lim are added, and the co-author trailer with a local hostname email on #1295 is a documented exception. Refs #1293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the existing doctor target after setup installs the dependencies. Keep its diagnostics visible and let setup succeed when doctor reports a problem. A dependency installation failure still stops setup.
Type
Verification
All 13 focused Makefile and environment-check tests passed. Verified the dry-run order and exercised clean, shadowing, and installation-failure scenarios with pip stubbed and the real doctor script.
Closes #1289