Skip to content

Fix pending closes in draft metrics noteFix pending closes in draft metrics note - #1310

Merged
yakew7 merged 1 commit into
yakew7:mainfrom
pvarchanavijay:fix-1304-pending-closes-note
Nov 9, 2026
Merged

yakew7 merged 1 commit into
yakew7:mainfrom
pvarchanavijay:fix-1304-pending-closes-note

Conversation

@pvarchanavijay

Copy link
Copy Markdown
Contributor

Summary

Fixes an issue where the draft metrics note does not include open issues referenced by local commits that are expected to close after merging.

Changes made

  • Added functionality to fetch open issue details, including issue numbers and titles.
  • Updated the draft note to include pending issues marked as "closing on merge".
  • Preserved the existing closed-issue count and contributor information.
  • Added tests to verify pending issue details and draft note generation.

Type

  • Audit
  • Explainer
  • Bug fix
  • Other

Testing

  • Ran python -m pytest tests/test_draft_metrics_row.py -v.
  • All 20 tests passed.

Linked issue

Closes #1304

@vercel

vercel Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@pvarchanavijay is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Hey @pvarchanavijay, your first PR on Fair Code, that's awesome, thank you.

This project is about making AI more accountable, and contributions like yours are what keep that work going. We'll review your changes shortly.

If you haven't already, give the contributing guide a quick read: it covers how audits are structured and what we look for in a review.

And if you're finding Fair Code useful or interesting, a star on the repo genuinely helps more people find it - no pressure, just appreciated.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

@yakew7 @ahmdkaml @propcgamer20-png - new PR touching a path you own, please review.

@yakew7
yakew7 merged commit e486272 into yakew7:main Nov 9, 2026
17 of 19 checks passed
yakew7 added a commit that referenced this pull request Nov 11, 2026
Started in one run with check_contributors.py --stub ... --commits (snapshot
moved to PR #1313, the pull request summaries filled in the stubs) and the
TODO sentences replaced: the pending-closes draft note (#1310), empty groups
in significance (#1311) and the configurable builder timeout (#1313). PR
#1311's commit is authored by PRIYANKA2272004, who has no pull request of
her own, so ranjanasri6's commit count and PRIYANKA2272004 are documented
exceptions, and an identity map row is added for renuvenugopal178.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

draft_metrics_row.py --note leaves out the issues the local commits are about to close

2 participants